test(e2e): data-integrity tier - concurrency, traversal, no-op#221
Merged
Conversation
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
e2e/integrity.test.ts(@p0, fully offline): a data-integrity tier that proves store guarantees the docs claim but no existing tier verifies. 7 tests, ~6s locally.Why
The single-writer serialization guarantee, path-traversal rejection, and no-op idempotence were asserted in docs but unproven end-to-end. Each test fails if the behavior regresses.
Tests
memory writeto distinct paths; asserts all exit 0, all readable, exactly 10 commits, clean working tree, noindex.lock,git fsckclean.../escape.md,@<vault>/../escape.md, and an absolute path are all rejected with a canonicalinvalid patherror; the escaped file is never created.echo body | memory write ... --body -writes and reads back.update --checkexits 0 with a calm verdict, no hang (hard timeout), no stack trace. Behavior-based so it survives the in-flight update-check rework.vault removeis non-destructive - files,.git, and full commit history stay on disk; only the registry entry is removed.Notes
createCliMachine,freePort, isolatedAGENTAGE_CONFIG_DIR, ephemeral ports,NO_COLOR). Local-only helpers live in the spec;helpers.tsuntouched (sibling PRs in flight).npm run verifygreen.